Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): allow inexact cross-generational pipette compatibility #4311

Merged
merged 12 commits into from
Oct 29, 2019

Conversation

b-cooper
Copy link
Contributor

overview

If user possesses more modern hardware (pipettes) that can be used in the same spec ranges as older
hardware specified in a given protocol, allow running protocol, and highlight difference with
support article CTA.

Closes #3598

changelog

  • When pipettes are missing, the warning text is now red to signal that you cannot proceed to calibrate or run

  • These two cases are now acceptable as "inexact matches":

    • Robot: p300 single gen2, Protocol: p300 single gen1
    • Robot: p20 single gen2, Protocol: p10 single gen1

review requests

  • Specify a pipette in a protocol that is not present on your robot, should see missing pipettes CTA as usual, but red text this time
  • Specify a p10 single gen1 or a p300 single gen1 in a protocol, and upload to a robot with either a p20 single gen2 or p300 single gen2 respectively. Should see an inexact match with support article link-out
  • confirm that if a pipette is missing and the other mount is an inexact match, only show the missing CTA

If user possesses more modern hardware (pipettes) that can be used in the same spec ranges as older
hardware specified in a given protocol, allow running protocol, and highlight difference with
support article CTA.

Closes #3598
@b-cooper b-cooper added app Affects the `app` project WIP labels Oct 28, 2019
@b-cooper b-cooper requested review from mcous and sfoster1 October 28, 2019 21:25
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #4311 into release_3.14.0 will increase coverage by 0.03%.
The diff coverage is 4.76%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release_3.14.0    #4311      +/-   ##
==================================================
+ Coverage           56.31%   56.34%   +0.03%     
==================================================
  Files                 890      890              
  Lines               24914    25022     +108     
==================================================
+ Hits                14030    14099      +69     
- Misses              10884    10923      +39
Impacted Files Coverage Δ
app/src/robot/selectors.js 84.02% <ø> (ø) ⬆️
app/src/components/FileInfo/MissingItemWarning.js 0% <0%> (ø)
...pp/src/components/FileInfo/ProtocolPipettesCard.js 0% <0%> (ø) ⬆️
.../src/components/FileInfo/useInstrumentMountInfo.js 0% <0%> (ø)
app/src/components/FileInfo/InstrumentItem.js 0% <0%> (ø) ⬆️
app/src/components/nav-bar/NavButton.js 0% <0%> (ø) ⬆️
app/src/components/FileInfo/ProtocolModulesCard.js 0% <0%> (ø) ⬆️
app/src/robot/api-client/client.js 85.16% <100%> (ø) ⬆️
opentrons/legacy_api/modules/__init__.py 65.04% <0%> (-15.73%) ⬇️
opentrons/hardware_control/simulator.py 84.61% <0%> (-0.86%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a33ada...54cdff4. Read the comment docs.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚙️

@b-cooper b-cooper changed the base branch from edge to release_3.14.0 October 28, 2019 23:38
@b-cooper b-cooper merged commit 95dae6a into release_3.14.0 Oct 29, 2019
@b-cooper b-cooper deleted the app_inexact-match-pips branch October 29, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants