Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix broken back-compat for pre-3.13.x robots #4203

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Oct 10, 2019

overview

Closes #4202

In #4099, I added a new argument to Session.create to support bundle execution, but missed the case where the App version was ahead of the robot server. This makes App backwards-compatible when calling Session.create via RPC.

changelog

review requests

Push v3.12.0 on to a robot and check:

@IanLondon IanLondon requested review from mcous and a team October 10, 2019 19:15
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick over catch ordering but functionality works when tested against 3.12.0 local dev server

app/src/robot/api-client/client.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4203 into hotfix_3.13.2 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           hotfix_3.13.2    #4203      +/-   ##
=================================================
- Coverage          57.88%   57.87%   -0.01%     
=================================================
  Files                857      857              
  Lines              24237    24240       +3     
=================================================
  Hits               14029    14029              
- Misses             10208    10211       +3
Impacted Files Coverage Δ
app/src/robot/api-client/client.js 85.16% <0%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b171cc0...ece391e. Read the comment docs.

@IanLondon IanLondon merged commit 9243a8d into hotfix_3.13.2 Oct 10, 2019
@IanLondon IanLondon deleted the app_fix-pre-v3.13-backcompat branch October 10, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants