Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): show spinner while robot logs are downloading #4158

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Oct 1, 2019

overview

This PR adds a spinner to the download robot logs button while logs are downloading

Known limitation: UI will only allow you to be downloading logs from one robot at a time. This is to make the implementation faster. We can revisit this from 3.13.1 or 3.14

changelog

  • feat(app): show spinner while robot logs are downloading

review requests

  • Spinner shows while logs are downloading
  • Spinner goes away when logs finish downloading
  • Spinner goes away if logs fail to download

Known limitation: UI will only allow you to be downloading logs from one robot at a time
@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project labels Oct 1, 2019
@mcous mcous requested review from sfoster1, ahiuchingau and a team October 1, 2019 22:02
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #4158 into release_3.13.0 will decrease coverage by 0.01%.
The diff coverage is 15.78%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release_3.13.0    #4158      +/-   ##
==================================================
- Coverage           57.87%   57.85%   -0.02%     
==================================================
  Files                 854      857       +3     
  Lines               24207    24219      +12     
==================================================
+ Hits                14010    14013       +3     
- Misses              10197    10206       +9
Impacted Files Coverage Δ
app/src/shell/index.js 100% <ø> (+29.41%) ⬆️
...c/components/RobotSettings/AdvancedSettingsCard.js 0% <0%> (ø) ⬆️
app/src/shell/robot-logs/actions.js 0% <0%> (ø)
app/src/shell/robot-logs/selectors.js 0% <0%> (ø)
app-shell/src/robot-logs.js 0% <0%> (ø) ⬆️
app/src/shell/robot-logs/reducer.js 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4c357...1442ef8. Read the comment docs.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely works!

@sfoster1 sfoster1 merged commit cd50c42 into release_3.13.0 Oct 1, 2019
@sfoster1 sfoster1 deleted the app_robot-logs-spinner branch October 1, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants