fix(app): Remove Electron RPC remote objects from Redux state #3820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the remote calls from the app to the shell were leaking Electron RPC remote objects into the Redux state. If the main process does anything weird to these remote objects, the Redux state might be mutated under our feet. This commit removes unnecessary remote calls and ensure returned objects are cloned into plain-old JS objects.
mcous
added
bug
app
11 tasks
Kadee80
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Ticket and fix
Some of the remote calls from the app to the shell were leaking Electron RPC (not to be confused with our Robot RPC API) remote objects into the Redux state.
If the main process does anything weird to these remote objects, the Redux state might be mutated under our feet, which in the worst case could white-screen the UI. This commit removes unnecessary remote calls and ensure returned objects are cloned into plain-old JS objects.
changelog
review requests
discoverysubstate is still populated correctly at launchconfigsubstate is still populated correctly at launch