Tempdeck in 3.9 having weird behavior

[sanni-t]

overview

Seems like there is a bug in modules discovery and driver<>simulator structure in the api..

current behavior

This behavior is observed occasionally- the tempdeck 'current temp' in run app would be stuck at some value that is not consistent with the tempdeck display (the display seems like the correct indicator. e.g, the tempdeck would read 15C and the app would say 33C when the tempdeck is cold to touch)

I was able to get the app to display correct value by switching to the modules & pipettes card in the app and then going back to the run page. So, it sounds like the discovered module object was reset to the correct one during card switching.

Another weird behavior observed on just one occasion was the tempdeck actually setting temperatures during simulation.

[sanni-t]

The inaccurate temperature status was being caused by mismatch in modules instances when a module was reconnected. This was because of how modules discovery used to work- by polling for connected devices continuously. This method of discovery was changed in #4441 so the robot is now aware of module connection/disconnection event, fixing the problem of getting stray instances of disconnected modules.
We weren't able to recreate the second issue of tempdeck setting temperatures during simulation. Marking this as solved for now.