fix(app): Re-enable change pipette and pipette settings #3475
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #3475 +/- ##
=========================================
+ Coverage 52.4% 52.49% +0.09%
=========================================
Files 796 796
Lines 23194 23246 +52
=========================================
+ Hits 12155 12204 +49
- Misses 11039 11042 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Please test on a robot with edge installed and one with an older version of the API!
-
attached pipettes card renders as expected
-
clicking [change/attach] opens change pipette modal (please confirm change pipette walkthrough still works as expected)
-
unrelated issue: new pipette selection dropdown ends the modal when selected, working on this separately
-
clicking [settings] for an attached pipettes pops up pipette config modal. (please confirm settings are still updatable.
|
Found another issue (separate maybe?): When I am in the |
| @@ -53,14 +53,14 @@ function AttachedPipettesCard(props: Props) { | |||
| <CardContentFlex> | |||
| <InstrumentInfo | |||
| mount="left" | |||
| name={props.robot.name} | |||
| robotName={props.robot.name} | |||
| {...props.left} | |||
There was a problem hiding this comment.
If I remember correctly, this spread is only to grab the pipette model, so it could be changed to:
model={props.left?.model}| {...props.left} | ||
| onChangeClick={props.clearMove} | ||
| showSettings={props.showLeftSettings} | ||
| /> | ||
| <InstrumentInfo | ||
| mount="right" | ||
| name={props.robot.name} | ||
| robotName={props.robot.name} | ||
| {...props.right} |
There was a problem hiding this comment.
Same change as above:
model={props.right?.model}
overview
This PR serves as a bug report and fix. A recent API update returns both a
nameandmodelfor attached pipettes. TheAttatchedInstrumentsCardandInstrumentInfowere usingnameforrobot.namewhich caused a conflict resulting in broken routes for change pipette and pipette settings.This PR changes
name(robot) prop torobotNamewhich fixes the pipette modal routes.This PR also found another bug with confirming detached pipettes. That should be fixed now as well.
changelog
review requests
Please test on a robot with edge installed and one with an older version of the API!
Files that are not affected by this PR but should be double checked if possible: