Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Clear deck cal request states on wizard exit #3378

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Apr 23, 2019

overview

Bug report + fix for stale error response states in the app during deck calibration. Exiting the wizard during an error condition should now clear all client-side DC state, allowing the user to retry DC instead of forcing them to restart the app.

changelog

  • fix(app): Clear deck cal request states on wizard exit

review requests

Please test on a real robot! WFH so no robot for me to test on

@mcous mcous added bug app Affects the `app` project ready for review fix PR fixes a bug labels Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #3378 into edge will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #3378      +/-   ##
==========================================
- Coverage   52.51%   52.43%   -0.09%     
==========================================
  Files         766      766              
  Lines       22763    22767       +4     
==========================================
- Hits        11954    11937      -17     
- Misses      10809    10830      +21
Impacted Files Coverage Δ
app/src/http-api-client/index.js 100% <ø> (ø) ⬆️
app/src/components/CalibrateDeck/NoPipetteModal.js 0% <ø> (ø) ⬆️
app/src/components/CalibrateDeck/index.js 0% <0%> (ø) ⬆️
app/src/http-api-client/calibration.js 58.62% <0%> (-37.61%) ⬇️
app/src/components/CalibrateDeck/InUseModal.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8d929...b523ff4. Read the comment docs.

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 🌆 .

Was able to recover from homing error at the end of deck calibration without having to shut down app 🥂

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦌 🤙

@mcous mcous merged commit 408b8aa into edge Apr 23, 2019
@mcous mcous deleted the app-fix-stale-dc-error branch April 23, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants