fix(app): Fix modules not populating the modules card #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laura-Danielle
added
app
mcous
reviewed
Mar 29, 2019
| @@ -9,8 +9,8 @@ type Props = { | |||
| } | |||
|
|
|||
| export default function ModulesCardContents (props: Props) { | |||
| const {modules, showThermo} = props | |||
| if (!modules || !modules[0] || !showThermo) return <NoModulesMessage /> | |||
| const {modules} = props | |||
There was a problem hiding this comment.
To preserve intended functionality, could we consider this change instead?
// ...
import filter from 'lodash/filter'
// ...
export default function ModulesCardContents (props: Props) {
const {showThermo} = props
const modules = filter(props.modules, m => {
return showThermo || m.name !== 'thermocycler'
})
if (modules.length === 0) return <NoModulesMessage />
return (
<React.Fragment>
{modules.map((mod, index) => (
<ModuleItem module={mod} key={index} />
))}
</React.Fragment>
)
}
Codecov Report
@@ Coverage Diff @@
## edge #3278 +/- ##
==========================================
- Coverage 53.58% 53.57% -0.01%
==========================================
Files 711 711
Lines 20739 20742 +3
==========================================
Hits 11112 11112
- Misses 9627 9630 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Logic was introduced into edge which made the modules (temperature + magnetic) not populate the modules card in the app even though the endpoint was returning correctly formatted data. We will need to do another alpha release once this is merged.
changelog
review requests
Please test this branch on your robot