feat(protocol-designer): update transfer form design #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanLondon
added
app
Codecov Report
@@ Coverage Diff @@
## edge #3221 +/- ##
==========================================
- Coverage 53.77% 53.72% -0.06%
==========================================
Files 698 699 +1
Lines 20455 20476 +21
==========================================
Hits 11000 11000
- Misses 9455 9476 +21
Continue to review full report at Codecov.
|
Kadee80
approved these changes
Mar 15, 2019
howisthisnamenottakenyet
suggested changes
Mar 15, 2019
howisthisnamenottakenyet
approved these changes
Mar 18, 2019
…te padding/margins
IanLondon
force-pushed
the
pd_update-transfer-form-design-3140
branch
from
f0d9eec to
7638f3b
Compare
IanLondon
commented
Mar 20, 2019
| @@ -26,23 +27,29 @@ | |||
| justify-content: flex-start; | |||
| } | |||
|
|
|||
| /* TODO: Ian 2019-03-14 delete probably (just used for Mix) */ | |||
There was a problem hiding this comment.
mix form stuff will be addressed in next PR to update Mix form design
Kadee80
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Closes #3140
This messes up Mix form, which will be updated in a follow-up PR. However, it should not break anything other than Mix form, including new protocol form, pipette setup, liquids tab, and adding/deleting ingredients in Starting Deck State. (Don't worry about Pause form either, that will be updated right after Mix is!)
This affects Components Library. I addressed our TODOs about replacing inline text with
i18ndata, and I didn't want to keep i18n responsible for capitalization of labels, so I changed the CSS forFormGroupto capitalize and to append a colon eg'some label' --> 'Some Label:'.To opt out of this default capitalization to labels ofNopeInputField,CheckboxField, andRadioGroup, you can pass the propnoCapitalize. I added this to all the places where it seemed relevant to Run App. This doesn't append a colon.I think now, Run App is only visibly affected in one way in the one place it uses
FormGroup: now colons are added to the labels in Pipette Config.changelog
review requests
Please ignore Mix and Pause forms for now!