Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Configure analytics to send Python and JSON protocol info #2946

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jan 22, 2019

overview

This PR wires up protocol data to protocol upload and run control events. Closes #2615 and closes #2618; see those tickets for acceptance criteria.

changelog

  • feat(app): Configure analytics to send Python and JSON protocol info

review requests

Required event data in tickets above.

  • In dev mode, check console log for "Trackable event"
  • In prod mode, check that the branch build goes all the way to mixpanel

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Jan 22, 2019
@mcous mcous requested review from umbhau, Kadee80 and a team January 22, 2019 21:07
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #2946 into edge will decrease coverage by 0.03%.
The diff coverage is 39.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #2946      +/-   ##
==========================================
- Coverage   51.78%   51.75%   -0.04%     
==========================================
  Files         663      665       +2     
  Lines       19002    19033      +31     
==========================================
+ Hits         9841     9851      +10     
- Misses       9161     9182      +21
Impacted Files Coverage Δ
app/src/robot/api-client/client.js 87.06% <ø> (+0.43%) ⬆️
app/src/protocol/protocol-data.js 77.77% <0%> (-15.56%) ⬇️
app/src/analytics/index.js 0% <0%> (ø) ⬆️
app/src/analytics/make-event.js 86.95% <100%> (+2.74%) ⬆️
app/src/analytics/selectors.js 14.28% <14.28%> (ø)
app/src/analytics/hash.js 14.28% <14.28%> (ø)
app/src/protocol/index.js 95.08% <66.66%> (-3.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b9573...3e69ea4. Read the comment docs.

Copy link

@umbhau umbhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested end-to-end

  • name, type, author, appname and appversion for json protocols
  • name, type, author, source for python
  • uploadSuccess, runStart, runFinish, and Cancel events

Passes AC from:
#2615 #2618

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛤

@mcous mcous merged commit 22f419d into edge Jan 24, 2019
@mcous mcous deleted the app_protocol-analytics branch January 24, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
3 participants