Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Implement clearer robot server upgrade/downgrade information #2807

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented Dec 11, 2018

overview

This PR closes #2401.

changelog

  • remove feature flag for the new upgrade/downgrade modal
  • remove feature flag for redirect on app upload to app update modal if app update available
  • remove legacy RobotUpdateModal files

review requests

Please see #2401 checklist for testing plan

@Kadee80 Kadee80 added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Dec 11, 2018
@Kadee80 Kadee80 requested a review from mcous December 11, 2018 20:16
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #2807 into edge will increase coverage by 0.67%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #2807      +/-   ##
==========================================
+ Coverage   51.04%   51.71%   +0.67%     
==========================================
  Files         659      656       -3     
  Lines       18038    18204     +166     
==========================================
+ Hits         9208     9415     +207     
+ Misses       8830     8789      -41
Impacted Files Coverage Δ
app/src/config/index.js 55.55% <ø> (ø) ⬆️
.../src/components/RobotSettings/UpdateRobot/index.js 0% <ø> (ø) ⬆️
app/src/components/RobotSettings/index.js 0% <ø> (ø) ⬆️
app/src/pages/Robots/index.js 0% <0%> (ø) ⬆️
app/src/pages/Robots/RobotSettings.js 0% <0%> (ø) ⬆️
app/src/robot/actions.js 91.66% <0%> (ø) ⬆️
app/src/robot/api-client/client.js 86.74% <0%> (+0.31%) ⬆️
app/src/protocol/protocol-data.js 95.65% <0%> (+4.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf60942...8d57576. Read the comment docs.

Copy link
Contributor Author

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on bitter moon

figure 1 (robot < app, app < latest)


robot = 3.5.1 | app = 3.6.0| latest = 3.6.2
https://zpl.io/beLo0YD

  • 


redirect to menu/app/update on load
  • 
always show UpdateAppModal first when there is appUpdate.available,regardless of upgrade downgrade/reinstall action
  • 
VersionList shows:
    • 
current app version
    • current robot version
  • available app update version
  • [view app update] links to menu/app/update
  • [click here] shows available upgrade release notes (for robot, not app)
  • [not now] closes modal, sets current available wheel version to ignored

figure 2 (robot = app, app < latest)

robot = 3.6.0 | app = 3.6.0 | latest =3.6.2
https://zpl.io/blZd0Pk

  • redirect to menu/app/update on load
  • always show UpdateAppModal first when there is appUpdate.available, regardless of upgrade downgrade/reinstall action
  • VersionList shows:
    • current app version
    • current robot version
    • available app update version
  • [click here] installs current available wheel (spinner modal screen)
  • [view app update] links to menu/app/update
  • [not now] closes modal, does not ignore this api version

figure 3 (robot > app, app < latest)


robot = 3.6.1 | app = 3.6.0| latest = 3.6.2
https://zpl.io/bz1AoWX

  • redirect to menu/app/update on load
  • always show UpdateAppModal first when there is appUpdate.available, regardless of upgrade downgrade/reinstall action
  • VersionList shows:
    • current app version
    • current robot version
    • available app update version
  • [click here] installs current available wheel (spinner modal screen)
  • [view app update] links to menu/app/update
  • [not now] closes modal, does not ignore this api version

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐢

figure 4 (robot < app, app = latest)

robot = 3.6.0 | app = 3.6.2 | latest = 3.6.2

https://zpl.io/amy5nBA

  • Upgrade auto-pop up (as long as this version is not previously ignored)
  • Robot InformationCard button reads [Upgrade]
  • SyncRobotModal shows upgrade message
  • VersionList shows:
    • current app version
    • current robot version
  • [not now] closes modal and ignores available upgrade version
  • [view robot server update] shows release notes
  • [update robot server] installs robot server upgrade

figure 5 (robot = app, app = latest)

robot = 3.6.2 | app = 3.6.2 | latest = 3.6.2

  • Robot InformationCard button reads [Reinstall]
  • ReinstallModal renders shows reinstall message
  • VersionList shows:
    • current app version
    • current robot version
  • [not now] closes modal and does not ignore current reinstall version
  • [reinstall] reinstalls current version

figure 6 (robot > app, app = latest)

robot = 3.7.0-beta1 | app = 3.6.2 | latest = 3.6.2
(This one is pretty weird, but can happen if more than one user interacts with a user and one of the users is running a beta app and then our example user here is running stable)

https://zpl.io/2jPQ4wx
gl

  • Robot InformationCard button reads [Downgrade]
  • SyncRobotModal renders shows downgrade message
  • VersionList shows:
    • current app version
    • current robot version
  • [not now] closes modal and does not ignore current reinstall version
  • [downgrade robot] reinstalls current version

Install inProgress/Complete

  • When install of any kind is inProgress, spinner modal renders
  • When install of any kind is complete (response) restart robot modal renders
  • [not now] closes modal
  • [restart] restarts robot

@Kadee80 Kadee80 merged commit d37e3aa into edge Dec 12, 2018
@Kadee80 Kadee80 deleted the app_remove-upgrade-feature-flag branch December 12, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot update: Upgrade/downgrade modal
2 participants