Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should not set labware of same type calibrated if labware is sharing slot #2778

Closed
mcous opened this issue Dec 5, 2018 · 3 comments
Closed
Assignees
Labels
app Affects the `app` project bug

Comments

@mcous
Copy link
Contributor

mcous commented Dec 5, 2018

overview

#2525 introduced a change to the app so that all labware of the same type will be flagged as calibrated once one labware of that type has been calibrated. However, when a labware is sharing a slot with something else (share=True, e.g. if it is on a module) the API will separate it's offset from other labware of the same type. Accordingly, the app will flag the share=True labware as calibrated when it is, in fact, not.

@mcous mcous added bug app Affects the `app` project labels Dec 5, 2018
@mcous mcous self-assigned this Dec 5, 2018
@emernic
Copy link

emernic commented Dec 7, 2018

Possibly related: Placing a piece of labware on top of the aluminum blocks of the temp deck causes my_labware.bottom() to slam the tip into the bottom of the container incorrectly. This bug occurs even when the labware on the temp deck is the only one of its type used. This does not seem to be an issue if the labware is placed directly on the temp deck with no aluminum block.

@mcous
Copy link
Contributor Author

mcous commented Dec 7, 2018

@emernic that sounds like an unrelated problem. The app doesn't have anything to do with robot/labware positioning (it's making simple API calls).

I would recommend reaching out to the support team and verifying that your protocol and calibration procedure is correct or opening a separate ticket with a minimum reproduction protocol

@mcous
Copy link
Contributor Author

mcous commented Aug 27, 2019

Closed by #3800

@mcous mcous closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug
Projects
None yet
Development

No branches or pull requests

2 participants