Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API regression: /server/update/ignore no longer functions #2365

Closed
mcous opened this issue Sep 26, 2018 · 2 comments
Closed

API regression: /server/update/ignore no longer functions #2365

mcous opened this issue Sep 26, 2018 · 2 comments
Labels
api Affects the `api` project bug
Milestone

Comments

@mcous
Copy link
Contributor

mcous commented Sep 26, 2018

overview

We added GET+POST /server/update/ignore in #1693 so that a robot could tell the app that it was ignoring a certain update (so that the app would not pop up an update alert modal). #1701 subsequently broke that functionality. Out of an abundance of caution, if the app cannot hit /server/update/ignore, it does not pop up the alert modal.

As we improve the robot update alert modal in the app, we need this functionality back so that the user is actually alerted to updates

current behavior

POST /server/update/ignore 404s

steps to reproduce

  1. Open the app with devtools on
  2. Click on a robot
  3. Note the failure to hit /server/update/ignore

expected behavior

/server/update/ignore should function like it did when it was added in #1693

@mcous mcous added bug api Affects the `api` project labels Sep 26, 2018
@mcous mcous added this to the Bugs milestone Sep 26, 2018
@sfoster1
Copy link
Member

Does this also happen with server/update/firmware?

@mcous
Copy link
Contributor Author

mcous commented Sep 26, 2018

Duplicated and closed by #2367

@mcous mcous closed this as completed Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project bug
Projects
None yet
Development

No branches or pull requests

2 participants