-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): Parse JSON protocols into state #2231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎃 🍶 🌊 📛
Codecov Report
@@ Coverage Diff @@
## edge #2231 +/- ##
==========================================
+ Coverage 29.67% 29.91% +0.24%
==========================================
Files 497 499 +2
Lines 7962 7985 +23
==========================================
+ Hits 2363 2389 +26
+ Misses 5599 5596 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I upload a bad JSON protocol, it swallows the error coming from RPC and shows the overview page with no pipettes or labware. (The warning is logged to the console but not visible to the user.) Calibrate is grayed out but I can click "Proceed to calibrate" button and get there anyway and it's all blank. Then if I go back to Protocol tab, I see the error page that I should have seen immediately after upload: "Your protocol could no be opened".
Working great for non-bad protocols!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕯️ 🍠 🍬
overview
This is the second of three PRs for #2129.
This PR pulls protocol file reading out of the legacy RPC API client and into its own state module. It also adds actual JSON parsing to JSON protocols.
The next PR will add selectors for JSON protocol metadata to wire them into the File Info page.
changelog
review requests
All tests can be run with virtual smoothie, but a real robot test would probably be helpful.
edge
edge
state.protocol.data
state.protocol.data
state.protocol