fix(app): Grab intercom handler from window on every call #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our support module was caching the intercom handler too early (before the window had a chance to load), resulting in all our intercom calls nooping. This change removes the caching so window.Intercom is always called correctly.
mcous
added
bug
app
4 tasks
mcous
commented
Sep 4, 2018
| @@ -32,9 +37,8 @@ export const supportMiddleware: Middleware = (store) => (next) => (action) => { | |||
| if (action.type === 'robot:CONNECT_RESPONSE') { | |||
| const state = store.getState() | |||
| const robot = state.robot.connection.connectRequest.name | |||
| const data = {user_id: userId, 'Robot Name': robot} | |||
| log.debug('Updating intercom data', {data}) | |||
| intercom('update', {data}) | |||
There was a problem hiding this comment.
This was an uncaught bug because intercom was always nooping; it should've been intercom('update', data)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Bug report + fix.
Our support module was caching the intercom handler too early (before the window had a chance to load, which is when the Intercom snippet actually assigns to
window.Intercom), resulting in all our intercom calls nooping. This change removes the caching so window.Intercom is alwayscalled correctly (as suggested by @IanLondon)
changelog
review requests
When you connect to a robot, you should see the "Robot Name" field of your intercom user update to that name. Hit me up over Slack for the correct intercom ID to use.