feat(app): Add attached pipette info to intercom support

[Kadee80]

overview

This PR closes #2019 by adding attached pipettes info to intercom data when a the api returns 'api:PIPETTES_SUCCESS'

changelog

• feat(app): Add attached pipette info to intercom support

review requests

Unfortunately, the imported intercom handler always returned as a noop for Intercom('update') calls. So we had to do it the old fashioned way with window.Intercom(...)

Intercom does not accept arrays or objects for values in custom data fields. So rather than just have a single data attribute Pipettes: {...} with all of the apps info about the pipettes, it needed to be split up into Left Pipette: model string etc.

TODO: (in the future)
Add pipette serial numbers to intercom once they are exposed by the api

We have a test intercom app for these PRs so we can avoid confusing support with our nonsense messages. I will ping you with the intercom ID you need to set in app, and a link to the dashboard to view the user data

Open app (with the intercom ID set that I share via slack)

make -C app dev OT_APP_INTERCOM_ID=xyz123

Also go to your Intercom user in the intercom webapp. Look for the "Details" section on the left of the page. To see our custom properties, you will have to click "Show __ Hidden" link.

1. Connect to a robot
2. View attached pipettes
   • "Robot Name" in Intercom user properties matches connected robot
   • "Pipette Model Left" and "Pipette Model Right" in user match connected pipettes
3. View attached pipettes of robot that you're not connected to
   • "Pipette Model Left" and "Pipette Model Right" remain unchanged
4. Connect to a robot with different (or empty) pipettes
   • "Pipette Model Left" and "Pipette Model Right" update or clear accordingly

[codecov]

Codecov Report

Merging #2140 into edge will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             edge    #2140      +/-   ##
==========================================
- Coverage   31.18%   31.15%   -0.03%     
==========================================
  Files         467      467              
  Lines        7689     7696       +7     
==========================================
  Hits         2398     2398              
- Misses       5291     5298       +7

Impacted Files	Coverage Δ
...pp/src/components/RobotSettings/ResetRobotModal.js	0% <ø> (ø)	⬆️
app/src/support.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af09a4b...1a8078b. Read the comment docs.

[IanLondon]

Maybe we should avoid intercom = noop altogether and always do window.Intercom && window.Intercom(args)? It's more verbose but IMO much easier to understand. This slippery bug came from mutating intercom in a weird way. With this change, if somehow the intercom script doesn't inject Intercom into window scope, then Run App will crash, which I think is what Mike was trying to avoid?

Or instead of window.Intercom && window.Intercom(stuff) each time, we could do

function callIntercom (...args) {
 if (window && window.Intercom) {
    window.Intercom(...args)
  } else {
    log.warn('window.Intercom is not available')
  }
}

then call that fn instead of intercom / window.Intercom

[mcous]

Will rebase this PR once #2179 is merged

[mcous]

Testing with @umbhau

1. Connect to a robot
2. View attached pipettes
   • "Robot Name" in Intercom user properties matches connected robot
   • "Pipette Model Left" and "Pipette Model Right" in user match connected pipettes
3. View attached pipettes of robot that you're not connected to
   • "Pipette Model Left" and "Pipette Model Right" remain unchanged
4. Connect to a robot with different (or empty) pipettes
   • "Pipette Model Left" and "Pipette Model Right" update or clear accordingly

[umbhau]

🌭

Requested changes implemented in #2179

[Laura-Danielle]

From Windows Computer:

Connect to a robot
View attached pipettes

• "Robot Name" in Intercom user properties matches connected robot
• "Pipette Model Left" and "Pipette Model Right" in user match connected pipettes
  View attached pipettes of robot that you're not connected to
• "Pipette Model Left" and "Pipette Model Right" remain unchanged
  Connect to a robot with different (or empty) pipettes
• "Pipette Model Left" and "Pipette Model Right" update or clear accordingly

Works, just have to refresh intercom a few times to get the fields to update. Doubt we can do anything to fix this.

[Laura-Danielle]

💃