feat(app): Show module name over labware on deckmaps #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
mcous
commented
Jul 23, 2018
|
|
||
| {!showSpinner && module && ( | ||
| // TODO(mc, 2018-07-23): displayName? | ||
| <ModuleNameOverlay name={module.name} width={width}/> |
There was a problem hiding this comment.
width prop unnecessary
Codecov Report
@@ Coverage Diff @@
## edge #1913 +/- ##
==========================================
- Coverage 32.89% 32.86% -0.03%
==========================================
Files 406 407 +1
Lines 6637 6643 +6
==========================================
Hits 2183 2183
- Misses 4454 4460 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This is the last remaining PR to close out the current sprint's modules tickets. It adds a module name overlay to any labware that are sitting on modules on the deck.
Closes #1739
changelog
review requests
Follow instructions in #1910 to stub out protocol (session) and actual modules and enable module with
OT_APP_MODULES=1. Then:OT_APP_MODULESis unset or set to0, no modules appear anywherePer discussion with @pantslakz over Slack, these do not line up with screens because:
ContainerNameOverlayto support module name would've been frustratingContainerNameOverlayis likely going to be refactored with the rest of the Deck components