Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Remove tip-probed check in calibrator selector #1847

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jul 10, 2018

overview

This PR serving as a bug report and a fix.

The getCalibrator selector was incorrectly checking tip-probe status to decide if a pipette could be used for labware calibration. Since tip-probe is optional, this PR removes that check to make sure the correct pipette is used.

changelog

  • fix(app): Remove tip-probed check in calibrator selector

review requests

  1. Load a protocol / robot with multi on left and single on right
  2. Do not tip probe
  3. Go through tiprack calibration so you end up with a tip on the right single channel pipette
  4. Proceed to labware calibration
  • Robot uses right, single-channel pipette with tip on for labware calibration

(Tested on Sunset)

@mcous mcous added bug app Affects the `app` project ready for review fix PR fixes a bug labels Jul 10, 2018
@mcous mcous requested review from Kadee80 and btmorr July 10, 2018 17:42
Copy link
Contributor

@btmorr btmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good. I don't know enough about the tests to understand the ramifications of that part of the change.

@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

Merging #1847 into edge will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #1847      +/-   ##
==========================================
- Coverage   34.55%   34.54%   -0.02%     
==========================================
  Files         380      380              
  Lines        6176     6175       -1     
==========================================
- Hits         2134     2133       -1     
  Misses       4042     4042
Impacted Files Coverage Δ
app/src/robot/selectors.js 82.11% <100%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619e2d9...c478143. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖

@mcous mcous merged commit bb50677 into edge Jul 10, 2018
@mcous mcous deleted the app_fix-calibrator-logic branch July 10, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants