fix(components): fix Deck component viewBox #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix Deck SVG viewBox - update Deck styles in PD - update DeckMap styles in Run App
IanLondon
added
app
Codecov Report
@@ Coverage Diff @@
## edge #1807 +/- ##
==========================================
- Coverage 33.98% 33.94% -0.05%
==========================================
Files 370 370
Lines 6055 6054 -1
==========================================
- Hits 2058 2055 -3
- Misses 3997 3999 +2
Continue to review full report at Codecov.
|
mcous
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Deck component SVG had a viewBox calculated from slot width, height, and spacing. Since the deck is actually bigger than that, this PR just uses hard-coded height and width to set the viewBox to the actual bounds of the Deck SVG.
changelog
review requests