-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): Add keyboard shortcuts to jog controls #1761
Conversation
} | ||
} | ||
|
||
getJogHandlers () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧀 🍰
Codecov Report
@@ Coverage Diff @@
## edge #1761 +/- ##
==========================================
- Coverage 34.91% 34.73% -0.18%
==========================================
Files 347 348 +1
Lines 5729 5761 +32
==========================================
+ Hits 2000 2001 +1
- Misses 3729 3760 +31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I can use arrow keys I really wanna hit Enter to proceed 🙊
overview
This PR adds keyboard shortcuts to the JogControls component used by both Deck Calibration jogging and Labware Calibration jogging.
Closes #1476
changelog
review requests
We added a
<HandleKeypress>
wrapper component to the component library to attachkeyup
listeners on component mount and unmount. We then refactored the app's generic<JogControls>
component to be class based and use<HandleKeypress>
.The
JogControls
refactor also involved trying to make the button construction more readable, so let me know what you think ofrenderJogControls
.Otherwise: