Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): no longer consider labware loaded late in protocol off-deck #17033

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Dec 4, 2024

fix RQA-3732

Overview

Logic in our util to determine required labware for a protocol was parsing protocol commands and considering everything loaded after a "non-prep" command to be loaded off-deck. While best practice is to load all labware at the beginning of a protocol, we should still show accurate locations for loadLabware commands issued at any point.

Test Plan and Hands on Testing

  1. Upload a protocol with stacked labware loaded after a non-prep command. In protocol setup, see that the labware is now displayed with correct load locations on ODD and desktop

Before:
ODD Before
Screenshot 2024-12-02 at 6 42 49 PM

After:
ODD After
Desktop After

  1. Upload a protocol with labware loaded off-deck. See that off-deck labware is included in the list of labware required for desktop protocol details

Before:
Off deck labware before

After:
Off deck labware after

Changelog

  1. Refactor getLabwareSetupItemGroups to no longer have the concept of initial setup commands so that the accurate load location is returned for all labware
  2. Remove specific parsing of commands that separates out labware loaded in each category in protocol details on ODD. Instead perform simple filtration to grab all load labware commands

Review requests

Take a look at the changes and screenshots

Risk assessment

Low

@smb2268 smb2268 marked this pull request as ready for review December 4, 2024 18:15
@smb2268 smb2268 requested a review from a team as a code owner December 4, 2024 18:15
@smb2268 smb2268 requested review from shlokamin, mjhuff and sfoster1 and removed request for a team and shlokamin December 4, 2024 18:15
@smb2268 smb2268 self-assigned this Dec 4, 2024
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Always nice when we can simplify things.

@smb2268 smb2268 merged commit 607e119 into edge Dec 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants