fix(app): no longer consider labware loaded late in protocol off-deck #17033
+13
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3732
Overview
Logic in our util to determine required labware for a protocol was parsing protocol commands and considering everything loaded after a "non-prep" command to be loaded off-deck. While best practice is to load all labware at the beginning of a protocol, we should still show accurate locations for
loadLabware
commands issued at any point.Test Plan and Hands on Testing
Before:
After:
Before:
After:
Changelog
getLabwareSetupItemGroups
to no longer have the concept of initial setup commands so that the accurate load location is returned for all labwareReview requests
Take a look at the changes and screenshots
Risk assessment
Low