fix(ChatDisplay/index.tsx): users are only able to download a protocol #17015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elyorcv
force-pushed
the
AUTH-1064-saving-protocol-incorrectly
branch
2 times, most recently
from
e45ac23 to
311d693
Compare
Elyorcv
force-pushed
the
AUTH-1064-saving-protocol-incorrectly
branch
5 times, most recently
from
6a319b2 to
d66207d
Compare
current when user clicks the download button it create a python for even an empty string.
Elyorcv
force-pushed
the
AUTH-1064-saving-protocol-incorrectly
branch
from
d66207d to
eaeee29
Compare
y3rsh
approved these changes
Dec 5, 2024
opentrons-ai-client/src/molecules/ChatDisplay/__tests__/ChatDisplay.test.tsx
Show resolved
Hide resolved
| @@ -106,7 +106,18 @@ export function ChatDisplay({ chat, chatId }: ChatDisplayProps): JSX.Element { | |||
|
|
|||
| const handleFileDownload = (): void => { | |||
| const lastCodeBlock = document.querySelector(`#${chatId}`) | |||
| const code = lastCodeBlock?.textContent ?? '' | |||
| const code = lastCodeBlock?.textContent?.trim() ?? '' | |||
There was a problem hiding this comment.
The logic here makes sense and I am guessing that we instruct the LLM to place the protocol contents in the last code block of the response? Feels a bit brittle but we do not need to address in this PR.
There was a problem hiding this comment.
For this version, we assume that there is only one code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, when users clicked the download button, it created a Python file even for an empty string.
Now, the system downloads only valid protocols that are not single-line and must include
def run(.Closes AUTH-1064
Test Plan and Hands on Testing
Changelog
Review requests
Look at the section
Test Plan and Hands on TestingRisk assessment
Low