fix(app): fix inescapable pipette wizard #17008
Merged
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
force-pushed
the
app_fix-inescapable-pipette-wizard
branch
4 times, most recently
from
9413276 to
189f6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RABR-675
Overview
It's possible to sometimes get stuck in the pipette wizard without an exit button if the error occurs while a command is executing or the maintenance run is trying to be deleted. Additionally (and I think this is how the bug ABR reported happens to begin with) - if an error does occur once during pipette flows, we were just closing the wizard without deleting the maintenance run.
handleCleanUpAndCloseconditionally closes the run if it does exist, which we definitely want to do if we error.Lastly, it's probably better to show an exit button while certain requests are pending and just disable it rather than avoid rendering an exit button altogether.
This control flow more closely follows what happens in
GripperWizardFlows, which is probably why ABR & QA haven't seen this bug crop up in that flow.Test Plan and Hands on Testing
Changelog
Risk assessment
low