fix(protocol-designer): fix deck map flicker with ot-2 deckmap #17000
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3630
Overview
Adjust the maxWidth of the protocol steps deck map to work with ot-2 and flex and remove the flicker
Test Plan and Hands on Testing
Upload the attached protocol and see that it desnt flicker when hovering over the timeline steps
untitled (1) (1).json
then upload the 2nd attached protocol and confirm that it als odoesn't flicker when hovering over the timeline steps
1.0 testing.json
additionally, introduce timeline errors with both protocols and see that the flickering doesn't occur
Changelog
Risk assessment
low