Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix copy for pristine well warning #16979

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 25, 2024

Overview

Remove starting deck state link from pristine well warning. Also, remove grid gap between timeline warning title and body.

Closes RQA-3710

Test Plan and Hands on Testing

  • create transfer step aspirating from empty well
  • verify that warning copy is correct and there is no gridgap between title and body
Screenshot 2024-11-25 at 5 03 52 PM

Changelog

  • fix copy and gridGap

Review requests

see test plan

Risk assessment

low

Remove starting deck state link from pristine well warning. Also, remove grid gap between timeline
warning title and body.

Closes RQA-3710
@ncdiehl11 ncdiehl11 requested a review from koji November 25, 2024 22:02
@ncdiehl11 ncdiehl11 self-assigned this Nov 25, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 25, 2024 22:04
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner November 25, 2024 22:04
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the quick fix

@ncdiehl11 ncdiehl11 merged commit 2dc3e1d into edge Nov 25, 2024
14 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_fix-pristine-well-warning branch November 25, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants