Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix estimator update command failure copy during drop tip #16884

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 19, 2024

Closes RQA-3583

Overview

Currently, the app inspects an errorType on a failed drop tip command to determine whether to throw the special case "home the gantry" error modal. Recently, the error type changed for failed update estimator commands, so the special modal was broken. Instead of special-casing the errorType for failed estimator commands, let's just assume that any failed estimator command is caused by an unknown position error and pop the special modal.

Note that this also handles any error in the same manner with a "MustHomeError" errorType, too.

Screenshot 2024-11-19 at 10 39 06 AM

Test Plan and Hands on Testing

Tested the following:

  • Drop tip flows work as expected outside of ER.
  • Drop tip flows work as expected in ER.
  • Throwing any non-estimator error shows the correct error modal during blowout.
  • Throwing any non-estimator error shows the correct error modal during move to addressable area.
  • Throwing any non-estimator error pops the correct error modal during error recovery.
  • The special error modal is shown when position is unknown during a move to addressable area command.

Changelog

  • The "must home" error modal correctly displays during drop tip wizard.

Risk assessment

lowish. This is just a refactor with quasi-monkey patching of the error object.

@mjhuff mjhuff requested a review from a team as a code owner November 19, 2024 15:34
@mjhuff mjhuff force-pushed the app_fix-estimator-errors-drop-tip branch 2 times, most recently from e4723f0 to e3e14f0 Compare November 19, 2024 15:42
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will work really well!

@mjhuff mjhuff force-pushed the app_fix-estimator-errors-drop-tip branch from e3e14f0 to 81d8fc7 Compare November 19, 2024 15:53
@mjhuff mjhuff merged commit 888a0ab into chore_release-8.2.0 Nov 19, 2024
30 checks passed
@mjhuff mjhuff deleted the app_fix-estimator-errors-drop-tip branch November 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants