fix(app): enable about plate reader button when run is in progress #16803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
commented
Nov 13, 2024
| @@ -150,7 +150,7 @@ export const ModuleOverflowMenu = ( | |||
| <Fragment key={`${index}_${String(module.moduleType)}`}> | |||
| <MenuItem | |||
| onClick={() => item.onClick(item.isSecondary)} | |||
| disabled={item.disabledReason || isDisabled} | |||
There was a problem hiding this comment.
This item.disabledReason field doesn't exist, but since item is typed as any here it wasn't causing an error
mjhuff
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3561
Overview
Enable plate reader card "About Module" button while run is in progress
Test Plan and Hands on Testing
Check the module overflow button on a desktop devices page module card for a plate reader while the device has a run in progress. This should now be enabled
Changelog
Add
isSettingDisabledprop to allow for some modules to have enabled overflow menu items even if a run is in progress. Make thisfalsefor plate reader "About Module" item so that it's always enabledReview requests
Quick code check/test if you're in office
Risk assessment
Low