Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use encoder position instead of homing gantry when holding plate reader lid. #16781

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Nov 12, 2024

Overview

The plate reader lid hits the Flex side window when the gantry homes while the gripper holds the lid, don't do that :)
Instead, let's update the gantry position from the encoders, so we don't have to go home at all.

RQA-3550

Test Plan and Hands on Testing

  • Make sure we don't sideswipe the plate reader lid on the Flex after estop
  • Make sure we can still handle the plate reader lid estop case

Changelog

  • don't home the x and y axes so we don't sideswipe the flex window with the plate reader lid
  • use engage_axes and update_axis_position_estimations instead of homing the axes

Review requests

makes sense?

Risk assessment

low, unreleased

@vegano1 vegano1 requested a review from a team as a code owner November 12, 2024 21:30
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for finding a surgical solution to this.

@vegano1 vegano1 changed the base branch from edge to chore_release-8.2.0 November 13, 2024 15:34
@vegano1 vegano1 merged commit 9e951da into chore_release-8.2.0 Nov 13, 2024
16 checks passed
@vegano1 vegano1 deleted the RQA-3550-dont-hit-flex-window branch November 13, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants