feat(app): Add resources page to more section #1631
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #1631 +/- ##
=========================================
- Coverage 34.4% 34.18% -0.22%
=========================================
Files 338 343 +5
Lines 5526 5561 +35
=========================================
Hits 1901 1901
- Misses 3625 3660 +35
Continue to review full report at Codecov.
|
| <p>Download a protocol to run on your robot</p> | ||
| <OutlineButton | ||
| Component="a" | ||
| href="http://protocols.opentrons.com/" |
|
|
||
| const TITLE = 'Protocol Library' | ||
|
|
||
| export default function LibraryCard () { |
There was a problem hiding this comment.
Do we need separate components for KnowledgeCard and LibraryCard? Seems like we could get away with a ExternalResourceCard that takes children or a message prop and an external link
There was a problem hiding this comment.
Fair enough. Will change with https comment below
app/src/pages/More/index.js
Outdated
| const {match: {path}} = props | ||
| return ( | ||
| <Switch> | ||
| <Redirect exact from={path} to={'/menu/app'} /> |
There was a problem hiding this comment.
to prop should use path to build the route so we can change the top level path (/menu) in only one place
<Redirect exact from={path} to={`${path}/app`} />
app/src/pages/More/index.js
Outdated
| <Switch> | ||
| <Redirect exact from={path} to={'/menu/app'} /> | ||
| <Route | ||
| path={'/menu/app'} |
There was a problem hiding this comment.
Should also use path to build route
path={`${path}/app`}Given the redirect above, it might be worth doing...
const appPath = `${path}/app`...up top for the Redirect's to and the Route's path
app/src/pages/More/index.js
Outdated
| component={AppSettings} | ||
| /> | ||
| <Route | ||
| path={'/menu/resources'} |
There was a problem hiding this comment.
Should also use path to build route
path={`${path}/resources`}
|
@Kadee80 some small edits: Knowledge base should say: |
overview
This PR closes #1607 - adds resources page to more section of the app.
changelog
AppSettingsandResourcespages in/More, refactor routesKnowledgeCardandLibraryCardto resources pagereview requests
Standards review. Please click around and make sure [more] NavButton is correctly highlighted. and nothing whitescreens.