feat(app): Add priority 2 analytics events #1627
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #1627 +/- ##
=========================================
+ Coverage 34.4% 34.46% +0.06%
=========================================
Files 338 338
Lines 5526 5530 +4
=========================================
+ Hits 1901 1906 +5
+ Misses 3625 3624 -1
Continue to review full report at Codecov.
|
app/src/analytics/make-event.js
Outdated
| } | ||
| } | ||
| // $FlowFixMe(ka, 2018-06-5): flow type robot:PAUSE | ||
| case 'robot:PAUSE': |
There was a problem hiding this comment.
I kinda want to trigger this on PAUSE_RESPONSE rather than PAUSE. If we do it on PAUSE_RESPONSE, then I think its properties would also include success and error like the protocolUpload event
app/src/analytics/make-event.js
Outdated
| return {name: 'runPause', properties: {}} | ||
|
|
||
| // $FlowFixMe(ka, 2018-06-5): flow type robot:CANCEL | ||
| case 'robot:CANCEL': |
There was a problem hiding this comment.
Same note about CANCEL vs CANCEL_RESPONSE
app/src/analytics/make-event.js
Outdated
| case 'robot:SESSION_RESPONSE': | ||
| return { | ||
| name: 'protocolUpload', | ||
| properties: { |
There was a problem hiding this comment.
Can you add a TODO to add file open type (upload button vs drag-n-drop) to this event?
Will likely involve attaching this information to the meta field of the SESSION_RESPONSE action itself somehow. Will get a little hairy...
app/src/analytics/make-event.js
Outdated
| @@ -45,8 +55,30 @@ export default function makeEvent (state: State, action: Action): ?Event { | |||
| const runTime = robotSelectors.getRunSeconds(state) | |||
| return {name: 'runFinish', properties: {runTime}} | |||
| } else { | |||
| // TODO(mc, 2018-05-28): runError event | |||
| return null | |||
| return {name: 'runError', | |||
There was a problem hiding this comment.
Sorry to nitpick, but can you throw in a newline so the { isn't on the same line as name? Also line 66 and line 76
Kadee80
force-pushed
the
app_analytics-p-2
branch
from
2dd801c to
9b653e3
Compare
Use responses instead of requests
Kadee80
force-pushed
the
app_analytics-p-2
branch
from
9b653e3 to
fc5e8f3
Compare
overview
This PR closes #1553 by adding level 2 priority tracking events and tests to the app.
changelog
review requests
correct_mixpanel_idin following command to run the app.make dev OT_APP_MIXPANEL_ID=correct_mixpanel_id OT_APP_ANALYTICS__OPTED_IN=1Upload Event:
Upload a protocol without errors (upload successful)
Upload a protocol errors (upload errors)
Run Events: