Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): modify the text style in the software update modal #13628

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Sep 22, 2023

Overview

add a couple of html tags to align with the design.

As I posted to app&ui channel, we will need to update the package and component to align with the design completely.
But right now, it's not a good time to do that. So this PR just try to align with the design as much as possible without a lot of efforts.

removed ballet points
Screenshot 2023-09-22 at 11 24 38 AM
Screenshot 2023-09-22 at 11 24 49 AM

Test Plan

Changelog

Review requests

Risk assessment

low

add a couple of html tags to align with the design
@koji koji requested a review from a team September 22, 2023 16:11
@koji koji marked this pull request as ready for review September 22, 2023 16:11
@koji koji requested a review from a team as a code owner September 22, 2023 16:11
@koji koji requested review from jerader and removed request for a team and jerader September 22, 2023 16:11
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #13628 (c65973e) into chore_release-7.0.0 (e963176) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13628      +/-   ##
=======================================================
- Coverage                71.31%   71.31%   -0.01%     
=======================================================
  Files                     2426     2426              
  Lines                    68197    68200       +3     
  Branches                  7947     7947              
=======================================================
+ Hits                     48635    48637       +2     
- Misses                   17699    17700       +1     
  Partials                  1863     1863              
Flag Coverage Δ
app 68.93% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/src/molecules/ReleaseNotes/index.tsx 66.66% <66.66%> (ø)

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🗒️

@koji koji merged commit 67eb2ec into chore_release-7.0.0 Sep 22, 2023
@koji koji deleted the fix_add-elements-for-mapping branch November 29, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants