feat(app): oDD banners for pipette calibration warning #13624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
requested review from
ncdiehl11,
sfoster1,
jerader,
mjhuff,
brenthagen and
a team
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13624 +/- ##
=======================================================
+ Coverage 71.31% 71.34% +0.02%
=======================================================
Files 2425 1588 -837
Lines 68200 52793 -15407
Branches 7951 3443 -4508
=======================================================
- Hits 48637 37664 -10973
+ Misses 17700 14594 -3106
+ Partials 1863 535 -1328
Flags with carried forward coverage won't be shown. Click here to find out more. |
koji
reviewed
Sep 21, 2023
Comment on lines
+62
to
+64
| {getShowPipetteCalibrationWarning(instrumentsQueryData) && ( | ||
| <PipetteRecalibrationWarning /> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {getShowPipetteCalibrationWarning(instrumentsQueryData) && ( | |
| <PipetteRecalibrationWarning /> | |
| )} | |
| {getShowPipetteCalibrationWarning(instrumentsQueryData) ? ( | |
| <PipetteRecalibrationWarning /> | |
| ): null} |
koji
reviewed
Sep 21, 2023
koji
reviewed
Sep 21, 2023
Comment on lines
+48
to
+49
| width={SPACING.spacing32} | ||
| height={SPACING.spacing32} |
There was a problem hiding this comment.
We avoid using SPACING for width, height, and size.
Suggested change
| width={SPACING.spacing32} | |
| height={SPACING.spacing32} | |
| size="3rem" |
koji
reviewed
Sep 21, 2023
| <Icon | ||
| name="alert-circle" | ||
| color={COLORS.yellow2} | ||
| width="45px" |
There was a problem hiding this comment.
Suggested change
| width="45px" | |
| size="1.75rem" |
sfoster1
reviewed
Sep 21, 2023
| @@ -0,0 +1,56 @@ | |||
| import * as React from 'react' | |||
There was a problem hiding this comment.
file should probably be PipetteRecalibrationODDWarning
koji
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Please ignore the comments I left.
For this, we should need to use https://www.figma.com/file/OIdG64Q5cgvEw82ish5Eee/Design-System-(Flex)?type=design&node-id=1224-67108&mode=design&t=Ah4TNB5qas6TWgOl-0
Co-authored-by: koji <[email protected]>
koji
reviewed
Sep 21, 2023
| : [] | ||
| if (failuresList.length > 0) { | ||
| return failuresList[0]?.kind === INCONSISTENT_PIPETTE_OFFSET | ||
| } else return false |
There was a problem hiding this comment.
nit
Suggested change
| } else return false | |
| } else { return false } |
koji
reviewed
Sep 21, 2023
| } from '@opentrons/components' | ||
| import { StyledText } from '../../atoms/text' | ||
|
|
||
| export const PipetteRecalibrationODDWarning = (): JSX.Element | null => { |
There was a problem hiding this comment.
Suggested change
| export const PipetteRecalibrationODDWarning = (): JSX.Element | null => { | |
| export function PipetteRecalibrationODDWarning(): JSX.Element | null { |
sfoster1
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RAUT-737
Overview
Add pipette calibration warning to Instruments tab and protocol setup/instruments on ODD
Test Plan
This warning should occur on ODD protocol run setup and instruments dashboard if two pipettes are attached that have calibration values differing by more than 1.5mm
I've tested this out with mock data on my dev server, here are screenshots:
Changelog
ProtocolInstrumentMountItemReview requests
Look over the code and test on an ODD if you have time!
Risk assessment
Low