Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add settings option to reset ssh authorized keys #13616

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Sep 21, 2023

Overview

"We need to be able to reset the SSH authorized keys file, so we don't ship robots with internal public keys" - @vegano1

On the ODD, the reset is included under Settings > Device Reset > Clear all stored data.

Desktop

desktop ssh clear

Test Plan

  • Push branch up to devkit. SSH into bot, confirm it's working, then clear all stored data. Observe no longer able to ssh into bot.
  • Repeat process using the desktop app using the image above as a reference.

Changelog

  • Added SSH deletion logic to ODD.
  • Added new checkbox deletion under robot settings on the desktop app.
  • Added related testing.

Review requests

Test on devkit or physical robot if you're feeling lucky

Risk assessment

low

@mjhuff mjhuff requested review from koji and a team September 21, 2023 16:04
@mjhuff mjhuff requested a review from a team as a code owner September 21, 2023 16:04
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #13616 (1db0db8) into chore_release-7.0.0 (1ac718e) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13616      +/-   ##
=======================================================
- Coverage                71.30%   71.30%   -0.01%     
=======================================================
  Files                     2425     2425              
  Lines                    68193    68200       +7     
  Branches                  7949     7951       +2     
=======================================================
+ Hits                     48628    48632       +4     
- Misses                   17703    17705       +2     
- Partials                  1862     1863       +1     
Flag Coverage Δ
app 68.90% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...edTab/AdvancedTabSlideouts/DeviceResetSlideout.tsx 62.90% <40.00%> (-2.01%) ⬇️
...c/organisms/RobotSettingsDashboard/DeviceReset.tsx 78.68% <100.00%> (+0.72%) ⬆️

@vegano1
Copy link
Contributor

vegano1 commented Sep 21, 2023

nice!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a robot, looks good to me!

@mjhuff mjhuff merged commit 8677b18 into chore_release-7.0.0 Sep 21, 2023
@mjhuff mjhuff deleted the app_reset-ssh-keys-in-settings branch September 21, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants