feat(app): add open door check for odd #13613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add open door status check to display open door alert modal for odd and fix protocol run header banner rendering bugin desktop app fix RQA-1604
koji
requested review from
jerader and
a team
and removed request for
a team and
jerader
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13613 +/- ##
=======================================================
- Coverage 71.32% 71.27% -0.06%
=======================================================
Files 2423 2428 +5
Lines 68161 68363 +202
Branches 7937 8005 +68
=======================================================
+ Hits 48619 48727 +108
- Misses 17687 17760 +73
- Partials 1855 1876 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add OpenDoorAlertModal design
Had a conversation on Snackbar for open door status with Rob and Seth and we decided to display the above modal instead Snackbar
add open door status check to display open door alert modal for odd
fix protocol run header banner rendering banner issue desktop app.
The latest alpha, if the door is open, the app shows banner.
The banner
close door before start running protocolmodal only shows up before running a protocol.Test Plan
Set up a protocol and open the door
Desktop app shows the banner
ODD shows the modal
run a protocol on Desktop and ODD then open door
Desktop show up the banner but that is different from the above banner
ODD shows the modal
close the door and resume a run
Changelog
Review requests
Risk assessment
low