fix(api): do not block refresh positions #13611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just found out that if the gripper jaw is reporting a value greater than the max jaw value for whatever reason, we won't be able to home/move any axes.
This is because we have this sanity check that raises an error whenever we try to set the jaw displacement. This is an issue for us now because whenever we home an axis, we first cache the motor positions for all available motors-- which also sets the jaw displacement value based on the jaw encoder position.
To fix this, instead of raising an error whenever the encoder value is out-of-bound, we're just going to show a warning and set the displacement to the max value to not block any motion.