Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): do not block refresh positions #13611

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

ahiuchingau
Copy link
Contributor

Overview

Just found out that if the gripper jaw is reporting a value greater than the max jaw value for whatever reason, we won't be able to home/move any axes.

This is because we have this sanity check that raises an error whenever we try to set the jaw displacement. This is an issue for us now because whenever we home an axis, we first cache the motor positions for all available motors-- which also sets the jaw displacement value based on the jaw encoder position.

To fix this, instead of raising an error whenever the encoder value is out-of-bound, we're just going to show a warning and set the displacement to the max value to not block any motion.

@ahiuchingau ahiuchingau requested a review from a team as a code owner September 20, 2023 21:55
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #13611 (380a486) into chore_release-7.0.0 (04da21d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.0   #13611   +/-   ##
====================================================
  Coverage                71.33%   71.33%           
====================================================
  Files                     2423     2423           
  Lines                    68162    68162           
  Branches                  7937     7937           
====================================================
  Hits                     48620    48620           
  Misses                   17687    17687           
  Partials                  1855     1855           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@sfoster1 sfoster1 merged commit 9d3b69b into chore_release-7.0.0 Sep 21, 2023
@sfoster1 sfoster1 deleted the api_do-not-block-refresh-positions branch September 21, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants