Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): exit module calibration copy #13594

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Sep 19, 2023

closes RQA-1653

Overview

Fix copy from "calibration in progress" to "robot is in motion" to match what the copy says for exiting out of pipette flows

Test Plan

Start module calibration and early exit. See that the in progress modal says the correct copy.

Changelog

change i18n key to another key

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner September 19, 2023 20:44
@jerader jerader requested review from smb2268 and a team and removed request for a team September 19, 2023 20:44
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #13594 (f255c45) into chore_release-7.0.0 (ffaa00f) will decrease coverage by 0.01%.
Report is 2 commits behind head on chore_release-7.0.0.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13594      +/-   ##
=======================================================
- Coverage                71.33%   71.32%   -0.01%     
=======================================================
  Files                     1587     2422     +835     
  Lines                    52788    68145   +15357     
  Branches                  3442     7931    +4489     
=======================================================
+ Hits                     37654    48603   +10949     
- Misses                   14599    17687    +3088     
- Partials                   535     1855    +1320     
Flag Coverage Δ
app 68.96% <0.00%> (+24.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/src/organisms/ModuleWizardFlows/index.tsx 2.19% <0.00%> (ø)

... and 834 files with indirect coverage changes

@jerader jerader merged commit 52646be into chore_release-7.0.0 Sep 19, 2023
@jerader jerader deleted the app_fix-copy-mod-cal-exiting branch September 19, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants