-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-client, app, react-api-client): Feat add robot door status check to desktop and odd #13585
Conversation
…hecks to desktop and odd add api-client and react-api-client to check door status via /robot/door/status endpoint close RQA-1614
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13585 +/- ##
=======================================================
+ Coverage 71.32% 71.33% +0.01%
=======================================================
Files 2422 2423 +1
Lines 68142 68178 +36
Branches 7934 7946 +12
=======================================================
+ Hits 48600 48634 +34
- Misses 17685 17688 +3
+ Partials 1857 1856 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having difficulty getting the snackbar to appear whenever a "newly uploaded protocol" toast is present. 9/10 times, the snackbar doesn't render. When it does render above the protocol added toast, it looks good!
If you can't figure out an exact reason why this is happening, I think we need something else on the screen to alert uses to close the door. Maybe a chip in the ProtocolRunHeader?
Code is great! Just one small nit.
One question about the protocol you used. |
Ah good point. One was not ready to run, the other was a magnetic block protocol. Here's the protocol I used: |
Thank you. However, the snackbar shows up and disappear after 7 sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the higher refetch interval will solve our current problems.
Thanks for doing all this! 🚪 🚀
Overview
add api-client and react-api-client to check door status via
/robot/door/status
endpointThis PR needs #13584 (Adding a new endpoint for the robot status)
For Flex, doorRequiredClosedForProtocol is always true, so in this PR the item is used as an alternative of isOT3.
[design]
Desktop
https://www.figma.com/file/0hYQ4lFJbAAI33jQMRt1Di/Release%3A-Desktop-June-Flex-launch?node-id=22521%3A106668&mode=dev
ODD
https://www.figma.com/file/AoTLAYuWawlaWItB1umOjr/Release%3A-Opentrons-Flex-Touchscreen?node-id=20416%3A122097&mode=dev
when a robot is missing modules/instruments or both -> not display Snackbar
when a robot is ready to run (instruments and modules are attached), but the door is open -> display Snackbar (7sec)
close RQA-1614
Test Plan
Desktop app
Banner will show up in the header and the run start button is disabled
Touchscreen app
Snackbar will show up and the play button is disabled
Changelog
api-client
anduseDoorQuery
toreact-api-client
for the new endpoint,/robot/door/status/
Review requests
Risk assessment
low