feat(robot-server): monitor door status #13584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it open? Is it closed? Only you can decide
SyntaxColoring
approved these changes
Sep 18, 2023
|
|
||
| @control_router.get( | ||
| "/robot/door/status", | ||
| summary="Get the status of the robot door.", |
There was a problem hiding this comment.
Is there a more general term than "robot door" that we should use to account for the fact that on the OT-2, this is also wired to the top window?
I'm also fine with just going with "door," since that's what the advanced setting says.
| ) -> None: | ||
| """Test the door status route.""" | ||
| decoy.when(hardware_api.door_status).then_return(state) | ||
| assert (await get_door_status(hardware_api)).data.state == state.name.lower() |
There was a problem hiding this comment.
.data -> .content.data to resolve type-checking errors.
Suggested change
| assert (await get_door_status(hardware_api)).data.state == state.name.lower() | |
| assert ( | |
| await get_door_status(hardware_api) | |
| ).content.data.state == state.name.lower() |
vegano1
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it open? Is it closed? Only you can decide
testing