fix(app): update gripper probe assets, ensure size is same as pipette cal #13579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pipette screen fix RQA-794
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13579 +/- ##
====================================================
Coverage 71.32% 71.32%
====================================================
Files 2422 2422
Lines 68142 68142
Branches 7934 7934
====================================================
Hits 48605 48605
Misses 17680 17680
Partials 1857 1857
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mjhuff
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-794
Overview
Match size of gripper calibration video to that of the pipette cal screen and update assets to final ones in drive (I couldn't tell if the final ones were in the code so I replaced them just in case)
Test Plan
Run through gripper calibration, ensure probing video is the correct size and not big like the screenshot in the linked ticket
Changelog
Review requests
Test this out!
Risk assessment
Low