fix(shared-data): Update low-volume accuracy functions and bottom plunger position #13571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## low-volume-pipetting #13571 +/- ##
========================================================
- Coverage 71.40% 71.38% -0.02%
========================================================
Files 2443 1587 -856
Lines 69147 52733 -16414
Branches 8312 3440 -4872
========================================================
- Hits 49373 37646 -11727
+ Misses 17838 14553 -3285
+ Partials 1936 534 -1402
Flags with carried forward coverage won't be shown. Click here to find out more. |
sfoster1
added a commit
that referenced
this pull request
Sep 15, 2023
…nger position (#13571) * low-volume bottom plunger position is 61.5 * adds 8ch low-volume functions * adds 1ch P50 low-volume function * update python side test for changed values --------- Co-authored-by: Seth Foster <[email protected]>
sfoster1
added a commit
that referenced
this pull request
Sep 15, 2023
…nger position (#13571) * low-volume bottom plunger position is 61.5 * adds 8ch low-volume functions * adds 1ch P50 low-volume function * update python side test for changed values --------- Co-authored-by: Seth Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tested with protocol running on DVT flex, and measured %D and %CV using plate-reader. Several 8ch multis pass our spec at 1ul, have not yet tested 1ch pipettes but can assume similar results. The 1ch low-volume accuracy function has not finished validation in SZ, but this function is guaranteed to be an incremental improvement for the beta release from what we have right now.
Test Plan
Changelog
Review requests
Risk assessment