Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): idle gripper should idle #13558

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

ahiuchingau
Copy link
Contributor

Overview

The logic for checking whether or not gripper needs to be fixed.

Test Plan

Changelog

Review requests

Risk assessment

@ahiuchingau ahiuchingau requested a review from a team as a code owner September 14, 2023 20:30
Copy link
Contributor

@fsinapi fsinapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but can the description of is_ready_for_idle get updated? It's currently pretty misleading.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #13558 (5c6984a) into chore_release-7.0.0 (c8aca82) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.0.0   #13558   +/-   ##
====================================================
  Coverage                71.31%   71.31%           
====================================================
  Files                     2419     2419           
  Lines                    68090    68090           
  Branches                  7911     7911           
====================================================
  Hits                     48557    48557           
  Misses                   17680    17680           
  Partials                  1853     1853           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@fsinapi fsinapi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup makes sense!

@ahiuchingau ahiuchingau merged commit 7003e62 into chore_release-7.0.0 Sep 14, 2023
@ahiuchingau ahiuchingau deleted the fix_idle-gripper-should-idle branch September 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants