fix(app): fix various app copy #13557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13557 +/- ##
=======================================================
- Coverage 71.30% 71.30% -0.01%
=======================================================
Files 2419 2419
Lines 68082 68083 +1
Branches 7908 7909 +1
=======================================================
Hits 48547 48547
- Misses 17683 17684 +1
Partials 1852 1852
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smb2268
force-pushed
the
app_copy-fixes
branch
from
8cf612f to
b01bec2
Compare
smb2268
force-pushed
the
app_copy-fixes
branch
from
b01bec2 to
062fa01
Compare
smb2268
force-pushed
the
app_copy-fixes
branch
from
062fa01 to
1f1da03
Compare
smb2268
requested review from
ncdiehl11 and
jerader
and removed request for
a team
jerader
approved these changes
Sep 14, 2023
Comment on lines
+8
to
+9
| "pipette_left": "pipette", | ||
| "pipette_right": "pipette", |
There was a problem hiding this comment.
can these be updated into 1 i18n key now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes two copy changes:
Test Plan
Changelog
See description
Review requests
Make sure copy is updated properly
Risk assessment
Low