Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add reinstall support for new robot update flows #13554

Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Sep 14, 2023

Closes RQA-1587

Overview

The recent robot update flows did not include logic for properly handling reinstall and downgrade cases. This PR adds proper support.

reinstall.flows.mov

NOTE: "Download" support was removed as there currently is no download progress in the shell/store. This support will be added in a future PR.

Test Plan

  • Build the branch and run the build.
  • Test the reinstall logic under Device Settings > Advanced > Reinstall (app and robot must be on the same version)

Changelog

  • Added proper modal support for upgrading/downgrading.
  • Added testing to cover these cases.

Risk assessment

low

Also adds support for robot downgrading.
@mjhuff mjhuff requested a review from a team September 14, 2023 17:54
@mjhuff mjhuff requested a review from a team as a code owner September 14, 2023 17:54
@mjhuff mjhuff requested review from shlokamin and removed request for a team September 14, 2023 17:54
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #13554 (c70c14d) into chore_release-7.0.0 (b4430d9) will increase coverage by 0.00%.
Report is 4 commits behind head on chore_release-7.0.0.
The diff coverage is 78.57%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           chore_release-7.0.0   #13554    +/-   ##
=====================================================
  Coverage                71.30%   71.30%            
=====================================================
  Files                     2420     2420            
  Lines                    68076    68262   +186     
  Branches                  7907     7982    +75     
=====================================================
+ Hits                     48539    48676   +137     
- Misses                   17685    17721    +36     
- Partials                  1852     1865    +13     
Flag Coverage Δ
app 68.94% <78.57%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../RobotSettings/UpdateBuildroot/ViewUpdateModal.tsx 82.60% <0.00%> (-0.73%) ⬇️
...ms/Devices/RobotSettings/UpdateBuildroot/index.tsx 78.94% <50.00%> (+1.16%) ⬆️
...RobotSettings/UpdateBuildroot/UpdateRobotModal.tsx 89.28% <88.88%> (-0.72%) ⬇️
...tings/UpdateBuildroot/RobotUpdateProgressModal.tsx 86.79% <100.00%> (-0.71%) ⬇️

... and 9 files with indirect coverage changes

@mjhuff mjhuff requested review from a team and koji and removed request for shlokamin and a team September 14, 2023 17:56
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Co-authored-by: koji <[email protected]>
@mjhuff mjhuff merged commit c8aca82 into chore_release-7.0.0 Sep 14, 2023
@mjhuff mjhuff deleted the app_fix-reinstall-and-downgrade-robot-update-flows branch September 14, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants