fix(app): fix pinned protocol deletion issue #13553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was that the right protocolId wasn't set correctly when tapping the delete button
koji
requested review from
b-cooper
and removed request for
a team and
b-cooper
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13553 +/- ##
====================================================
Coverage 71.31% 71.31%
====================================================
Files 2419 2419
Lines 68080 68082 +2
Branches 7908 7908
====================================================
+ Hits 48550 48552 +2
+ Misses 17679 17678 -1
- Partials 1851 1852 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
approved these changes
Sep 14, 2023
| @@ -39,15 +39,15 @@ export function ProtocolCard(props: { | |||
| protocol: ProtocolResource | |||
| longPress: React.Dispatch<React.SetStateAction<boolean>> | |||
| setShowDeleteConfirmationModal: (showDeleteConfirmationModal: boolean) => void | |||
| setTargetProtocol: (targetProtocol: ProtocolResource) => void | |||
| setTargetProtocolId: (targetProtocolId: string) => void | |||
There was a problem hiding this comment.
yup this seems a lot better to grab the protocolId rather than the whole protocol resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The issue was that the right protocolId wasn't set correctly when tapping the delete button.
delete_protocol.mov
fix RQA-1588
Test Plan
Changelog
Review requests
Risk assessment
low