Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): update thermocycler calibration animation #13541

Merged

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Sep 13, 2023

RQA-1479

Overview

The placeholder video for the place adapter step of module calibration for the thermocycler showed an empty thermocycler block. Here, we update to show a more accurate representation of the thermocycler aluminum block.
Screen Shot 2023-09-13 at 10 26 12 AM

Test Plan

  • Begin module calibration for thermocycler module GEN2
  • Verify that the correct animation renders (showing thermocycler 96-well aluminum block instead of empty block)

Changelog

  • update thermocycler calibration adapter placement video to latest

Risk assessment

low

…latest

The placeholder video for the place adapter step of module calibration for the thermocycler showed
an empty thermocycler block. Here, we update to show a more accurate representation of the
thermocycler aluminum block.
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner September 13, 2023 14:25
@ncdiehl11 ncdiehl11 requested review from TamarZanzouri and removed request for a team September 13, 2023 14:25
@ncdiehl11 ncdiehl11 self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #13541 (0f43749) into chore_release-7.0.0 (69decb1) will decrease coverage by 0.59%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13541      +/-   ##
=======================================================
- Coverage                71.89%   71.31%   -0.59%     
=======================================================
  Files                     2370     2420      +50     
  Lines                    66643    68081    +1438     
  Branches                  7708     7907     +199     
=======================================================
+ Hits                     47913    48549     +636     
- Misses                   16901    17680     +779     
- Partials                  1829     1852      +23     
Flag Coverage Δ
app 68.90% <ø> (-2.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@ncdiehl11 ncdiehl11 merged commit 67468ea into chore_release-7.0.0 Sep 13, 2023
@ncdiehl11 ncdiehl11 deleted the app_update-thermocycler-calibration-asset branch September 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants