fix(api): disallow moving a fixed-trash labware #13534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
added
the
robot-svcs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13534 +/- ##
====================================================
Coverage 71.32% 71.32%
====================================================
Files 1586 1586
Lines 52792 52792
Branches 3437 3437
====================================================
Hits 37656 37656
Misses 14606 14606
Partials 530 530
Flags with carried forward coverage won't be shown. Click here to find out more. |
SyntaxColoring
approved these changes
Sep 12, 2023
sanni-t
reviewed
Sep 12, 2023
Comment on lines
95
to
97
| if labware_validation.validate_if_labware_is_fixed_trash( | ||
| current_labware_definition | ||
| ): |
There was a problem hiding this comment.
I think we should just use the labware_view.is_fized_trash() check to test if this is the fixed trash. We really only care about the 'fixed' trash in slot 12/ A3 and want to keep that fixed/ unmovable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
follow up work for #13504.
disallow moving a labware if it has a fixed trash quirk.
Test Plan
try moving a fixed trash labware. make sure it raises.
try moving a non fixed-trash labware - make sure it works as expected.
Changelog
Risk assessment
low. should only affect fixed-trash labware in move-labware.