-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): fix TC allows module calibration with lid closed #13533
Conversation
fix TC allows module calibration with lid closed fix RQA-1519
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13533 +/- ##
=======================================================
- Coverage 71.30% 71.27% -0.03%
=======================================================
Files 2418 2419 +1
Lines 68007 68298 +291
Branches 7896 7980 +84
=======================================================
+ Hits 48492 48680 +188
- Misses 17668 17748 +80
- Partials 1847 1870 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, was able to see the TC open lid command called in the network tab. Just need the additional logic for when toggleLatch()
is called
@@ -158,9 +158,6 @@ export function RobotSettingsCalibration({ | |||
: null | |||
) | |||
|
|||
console.log('pipetteOffsetCalibrations', pipetteOffsetCalibrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔪
@@ -256,6 +259,24 @@ export const ModuleCard = (props: ModuleCardProps): JSX.Element | null => { | |||
if (!isLatchClosed) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need additional logic in here to check if the module is a heater-shaker type, otherwise, the command is emitted even if you are launching the module cal flow for the thermocycler and the h-s attached to the robot has a closed latch.
Overview
fix TC allows module calibration with lid closed
close RQA-1519
ToDo update test cases later
Test Plan
Changelog
Review requests
Risk assessment
low