Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add module calibration data to download #13511

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Sep 11, 2023

closes RAUT-702

Overview

We need to add module calibration data to the .json download from the robot settings page.

Test Plan

  • verify that Flex calibration data download includes module calibration data (even if empty)

Changelog

  • add module calibration data to downloaded calibration data by querying modules endpoint
  • enable calibration data download button at all times for Flex

Risk assessment

low

We need to add module calibration data to calibration data download from the robot settings page.
(for Flex only)
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner September 11, 2023 19:30
@ncdiehl11 ncdiehl11 self-assigned this Sep 11, 2023
@ncdiehl11 ncdiehl11 requested review from shlokamin and removed request for a team September 11, 2023 19:30
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #13511 (c1c24b5) into chore_release-7.0.0 (dfa0892) will decrease coverage by 0.01%.
Report is 10 commits behind head on chore_release-7.0.0.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13511      +/-   ##
=======================================================
- Coverage                71.33%   71.32%   -0.01%     
=======================================================
  Files                     2418     2418              
  Lines                    67908    68229     +321     
  Branches                  7876     8011     +135     
=======================================================
+ Hits                     48443    48667     +224     
- Misses                   17623    17703      +80     
- Partials                  1842     1859      +17     
Flag Coverage Δ
app 68.83% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...botSettingsCalibration/CalibrationDataDownload.tsx 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@koji koji requested review from a team and removed request for shlokamin September 12, 2023 00:50
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
Worked as expected with a Flex and an OT-2

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ncdiehl11 ncdiehl11 merged commit d0edba9 into chore_release-7.0.0 Sep 12, 2023
@ncdiehl11 ncdiehl11 deleted the app_download_module_calibration_data branch September 12, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants