fix(app): fix module calibration while h/s is shaking #13507
Conversation
When calibrate heater-shaker, the app will send stop shaking command. fix RQA-1518
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13507 +/- ##
=======================================================
+ Coverage 71.33% 71.37% +0.03%
=======================================================
Files 2418 1586 -832
Lines 67908 52728 -15180
Branches 7876 3435 -4441
=======================================================
- Hits 48443 37635 -10808
+ Misses 17623 14564 -3059
+ Partials 1842 529 -1313
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -225,6 +231,22 @@ export const ModuleCard = (props: ModuleCardProps): JSX.Element | null => { | |||
| } | |||
|
|
|||
| const handleCalibrateClick = (): void => { | |||
| if (module.moduleType === HEATERSHAKER_MODULE_TYPE) { | |||
There was a problem hiding this comment.
I would also check if the currentSpeed status is a number > 0, so we would only emit the command if the module is shaking. Additionally, maybe we can emit a "close latch" command as well, only if the latch is opened?
|
|
||
| const handleCalibrate = (): void => { | ||
| if (module.attachedModuleMatch?.moduleType === HEATERSHAKER_MODULE_TYPE) { |
|
|
||
| const requiredAttachOrCalibratePipette = | ||
| formattedPipetteOffsetCalibrations.length === 0 || | ||
| (formattedPipetteOffsetCalibrations[0].lastCalibrated == null && | ||
| formattedPipetteOffsetCalibrations[1].lastCalibrated == null) | ||
|
|
||
| const handleCalibration = (): void => { | ||
| if (attachedModule.moduleType === HEATERSHAKER_MODULE_TYPE) { |
| const { getByRole } = render(props) | ||
|
|
||
| getByRole('button', { name: 'Calibrate' }).click() | ||
| expect(props.handleCalibrateClick).toHaveBeenCalled() |
There was a problem hiding this comment.
maybe you can further add on to this test to see if the useCreateLiveCommand gets called with the correct command
There was a problem hiding this comment.
Testing createLiveCommand is kind of complicated so I will skip this time but created a ticket under RAUT.
I will follow it later.
| @@ -225,7 +234,30 @@ export const ModuleCard = (props: ModuleCardProps): JSX.Element | null => { | |||
| } | |||
|
|
|||
| const handleCalibrateClick = (): void => { | |||
| setshowCalModal(true) | |||
| if (!isLatchClosed) { | |||
There was a problem hiding this comment.
I think we need to switch the order of these, right? If the latch is open, the module can't be shaking. So it's better to check if it is shaking then check if the latch is open, i think.
There was a problem hiding this comment.
actually, i guess either way works since you won't run into a situation where you need to run both the commands in a specific order 🤔
There was a problem hiding this comment.
I think stop shaking and open a latch would be natural.
I will change the order.
Overview
When calibrate heater-shaker, the app will send stop shaking command.
check a module type (h/s),
currentSpeed > 0and latch is open/close.fix RQA-1518
Test Plan
Changelog
Review requests
Risk assessment
low