-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): run Disco animation after first-time-setup completion #13505
feat(app): run Disco animation after first-time-setup completion #13505
Conversation
…-time setup completes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13505 +/- ##
====================================================
Coverage 71.33% 71.33%
====================================================
Files 2419 2418 -1
Lines 67910 67914 +4
Branches 7876 7876
====================================================
+ Hits 48443 48448 +5
+ Misses 17625 17624 -1
Partials 1842 1842
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because this component is the same rename component used in robot settings, the disco animation will also happen when you rename the robot from there.
i think what we probably want is for the WelcomeModal
(which is what gets rendered right after you finish set up) to trigger the disco light on mount. you can do that by using the useEffect hook by passing it an empty dependency array. but also if you dont wanna deal with this someone from app ui can do it
I'm pretty sure that (at least on the 7.0.0 release branch) this component is only used at the end of the setup flow - the settings page just has the one page with a textbox and then goes back to the settings page once a name is entered. Either way, I agree that syncing this to show up with the welcome modal makes more sense, will do 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Overview
Very simple PR to add in a "disco" animation when the first time setup flow is completed, per status bar design specs. The confluence doc stated "user completes robot setup", so I just set it up to run when the user confirms the robot's name (see vid below).
Test Plan
Tested on Flexy McFlexFace
20230908_130235.mp4
Changelog
Review requests
Mostly want to make sure this is the correct place to put this.
Risk assessment
Pretty low